netdev - Re: [PATCHv2 net-next] erspan: set bso bit based on mirrored packet's len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180520.183235.1631404265072288763.davem@davemloft.net>
Date:   Sun, 20 May 2018 18:32:35 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     u9012063@...il.com
Cc:     netdev@...r.kernel.org, tobin@...orbit.com
Subject: Re: [PATCHv2 net-next] erspan: set bso bit based on mirrored
 packet's len

From: William Tu <u9012063@...il.com>
Date: Fri, 18 May 2018 19:41:01 -0700

> Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not
> handled.  BSO has 4 possible values:
>   00 --> Good frame with no error, or unknown integrity
>   11 --> Payload is a Bad Frame with CRC or Alignment Error
>   01 --> Payload is a Short Frame
>   10 --> Payload is an Oversized Frame
> 
> Based the short/oversized definitions in RFC1757, the patch sets
> the bso bit based on the mirrored packet's size.
> 
> Reported-by: Xiaoyan Jin <xiaoyanj@...are.com>
> Signed-off-by: William Tu <u9012063@...il.com>
> ---
> v1->v2
>   Improve code comments, make enum erspan_bso clearer

Applied, thanks William.