netdev - Re: [PATCH net-next] r8169: fix network error on resume from suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 20 May 2018 18:39:12 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: fix network error on resume from
 suspend

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sat, 19 May 2018 10:29:33 +0200

> This commit removed calls to rtl_set_rx_mode(). This is ok for the
> standard path if the link is brought up, however it breaks system
> resume from suspend. Link comes up but no network traffic.
> 
> Meanwhile common code from rtl_hw_start_8169/8101/8168() was moved
> to rtl_hw_start(), therefore re-add the call to rtl_set_rx_mode()
> there.
> 
> Due to adding this call we have to move definition of rtl_hw_start()
> after definition of rtl_set_rx_mode().
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> Fixes: 82d3ff6dd199 ("r8169: remove calls to rtl_set_rx_mode")

Applied, thank you.