netdev - Re: [PATCH v2] Revert "alx: remove WoL support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180520.231820.868530785962553925.davem@davemloft.net>
Date:   Sun, 20 May 2018 23:18:20 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     acelan.kao@...onical.com
Cc:     jcliburn@...il.com, chris.snook@...il.com, rakesh@...era.com,
        netdev@...r.kernel.org, emily.chien@...onical.com, andrew@...n.ch,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Revert "alx: remove WoL support"

From: AceLan Kao <acelan.kao@...onical.com>
Date: Mon, 21 May 2018 11:14:00 +0800

> We are willing to fix the issue, but we don't have a machine to
> reproduce it, and the WoL feature has been removed 5 years ago, it's
> hard to find those buggy machines.

Have you bothered to ask the person who did the revert?

> WoL is a feature that is only used by a very small group of people,
> and the wake up issue looks like only happens on some
> platforms. Which means only small part of the group of people are
> affected.

One of those people was the wireless networking stack maintainer.

> So, it's not a serious issue worth to remove it from alx driver.

I disagree.

You must fix the regression solved by the revert, before adding
WoL support back to the driver.

I'm not going to say this again.

Thank you.