netdev - Re: [PATCH net-next 2/8] qed: Add support for tlv request processing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180521.123021.1436869076066974461.davem@davemloft.net>
Date:   Mon, 21 May 2018 12:30:21 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     sudarsana.kalluru@...ium.com
Cc:     netdev@...r.kernel.org, Ariel.Elior@...ium.com,
        chad.dupuis@...ium.com, manish.rangankar@...ium.com
Subject: Re: [PATCH net-next 2/8] qed: Add support for tlv request
 processing.

From: Sudarsana Reddy Kalluru <sudarsana.kalluru@...ium.com>
Date: Mon, 21 May 2018 03:40:12 -0700

> +struct qed_tlv_parsed_buf {
> +	/* To be filled with the address to set in Value field */
> +	u8 *p_val;

Assignments to this pointer are cast hundreds of times, like:

> +			p_buf->p_val = (u8 *)&p_drv_buf->rx_frames;

Over and over again.

Just make p_val a void pointer, and then you don't need any of the
casts at all.