netdev - Re: [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 May 2018 11:17:05 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        Networking <netdev@...r.kernel.org>, cake@...ts.bufferbloat.net,
        Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [PATCH net-next v13 3/7] sch_cake: Add optional ACK filter



On 05/21/2018 11:08 AM, Eric Dumazet wrote:
> 
> 
> On 05/21/2018 10:35 AM, Toke Høiland-Jørgensen wrote:
> 
>> Ah yes, sequence number wrapping. I was thinking I needed to deal with
>> that, and then got sidetracked and forgot about it. Will fix.
>>
>> Other than that, do you agree that this approach to SACK and header
>> handling can work?
> 
> Unfortunately this does not handle dsack (RFC 2883, and  3708) properly, I believe.
> 

Since I will be traveling for the next ~10 days, with possibly no Internet access,
or time to review patches, please CC other Google TCP experts for the next versions.

Thanks.