netdev - Re: [PATCH bpf-next 0/8] AF_XDP follow-up patches, uapi and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e3e8dba-0920-c488-b775-09db0b682295@iogearbox.net>
Date:   Tue, 22 May 2018 10:59:55 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Björn Töpel <bjorn.topel@...il.com>,
        magnus.karlsson@...el.com, magnus.karlsson@...il.com, ast@...com,
        netdev@...r.kernel.org
Cc:     Björn Töpel <bjorn.topel@...el.com>
Subject: Re: [PATCH bpf-next 0/8] AF_XDP follow-up patches, uapi and cleanups

On 05/22/2018 09:34 AM, Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@...el.com>
> 
> This the second follow-up set. The first four patches are uapi
> changes:
> 
> * Removing rebind support
> * Getting rid of structure hole
> * Removing explicit cache line alignment
> * Stricter bind checks
> 
> The last patches do some cleanups, where the umem and refcount_t
> changes were suggested by Daniel.
> 
> * Add a missing write-barrier and use READ_ONCE for data-dependencies
> * Clean up umem and do proper locking
> * Convert atomic_t to refcount_t
> 
> Björn Töpel (7):
>   xsk: remove rebind support
>   xsk: fill hole in struct sockaddr_xdp
>   xsk: remove explicit ring structure from uapi
>   samples/bpf: adapt xdpsock to the new uapi
>   xsk: add missing write- and data-dependency barrier
>   xsk: simplified umem setup
>   xsk: convert atomic_t to refcount_t
> 
> Magnus Karlsson (1):
>   xsk: proper queue id check at bind
> 
>  include/uapi/linux/if_xdp.h |  46 ++++++++---------
>  net/xdp/xdp_umem.c          |  85 +++++++++++++++---------------
>  net/xdp/xdp_umem.h          |   5 +-
>  net/xdp/xsk.c               | 105 +++++++++++++++++++++++--------------
>  net/xdp/xsk_queue.h         |  17 ++++++
>  samples/bpf/xdpsock_user.c  | 123 +++++++++++++++++++++++++++-----------------
>  6 files changed, 225 insertions(+), 156 deletions(-)

LGTM, applied to bpf-next, thanks guys!