netdev - Re: [PATCH net-next v4 1/3] ipv4: support sport, dport and ip_proto in RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJieiUjvpR-QmPifBDUoWsWVWHBCtp8_pDzjba9s21-Fyv4=0w@mail.gmail.com>
Date:   Tue, 22 May 2018 08:45:49 -0700
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        David Ahern <dsa@...ulusnetworks.com>,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next v4 1/3] ipv4: support sport, dport and ip_proto
 in RTM_GETROUTE

On Tue, May 22, 2018 at 8:04 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>
>
> On 05/22/2018 07:51 AM, Roopa Prabhu wrote:
>> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>>
>>
>
> ...
>
>> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
>> index 4d622112..cf5cfc5 100644
>> --- a/net/ipv4/fib_frontend.c
>> +++ b/net/ipv4/fib_frontend.c
>> @@ -649,6 +649,10 @@ const struct nla_policy rtm_ipv4_policy[RTA_MAX + 1] = {
>>       [RTA_ENCAP]             = { .type = NLA_NESTED },
>>       [RTA_UID]               = { .type = NLA_U32 },
>>       [RTA_MARK]              = { .type = NLA_U32 },
>> +     [RTA_TABLE]             = { .type = NLA_U32 },
>> +     [RTA_IP_PROTO]          = { .type = NLA_U8 },
>> +     [RTA_SPORT]             = { .type = NLA_U16 },
>> +     [RTA_DPORT]             = { .type = NLA_U16 },
>>  };
>
> Hi Roopa
>
> RTA_TABLE addition looks like a bug fix for net tree ?
>
> This should be sent as an independent patch IMO.
>
> Thanks.

sure, I can do that. thanks.