netdev - Re: [PATCH net] dccp: don't free ccid2_hc_tx_sock struct in dccp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180522.135543.1918786994671292064.davem@davemloft.net>
Date:   Tue, 22 May 2018 13:55:43 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     alexey.kodanev@...cle.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] dccp: don't free ccid2_hc_tx_sock struct in
 dccp_disconnect()

From: Alexey Kodanev <alexey.kodanev@...cle.com>
Date: Mon, 21 May 2018 19:28:44 +0300

> Syzbot reported the use-after-free in timer_is_static_object() [1].
> 
> This can happen because the structure for the rto timer (ccid2_hc_tx_sock)
> is removed in dccp_disconnect(), and ccid2_hc_tx_rto_expire() can be
> called after that.
> 
> The report [1] is similar to the one in commit 120e9dabaf55 ("dccp:
> defer ccid_hc_tx_delete() at dismantle time"). And the fix is the same,
> delay freeing ccid2_hc_tx_sock structure, so that it is freed in
> dccp_sk_destruct().
 ...
> Reported-by: syzbot+5d47e9ec91a6f15dbd6f@...kaller.appspotmail.com
> Signed-off-by: Alexey Kodanev <alexey.kodanev@...cle.com>

Applied and queued up for -stable, thanks.