netdev - Re: [PATCH net-next] bpfilter: don't pass O_CREAT when opening console for debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1857b28c-ae09-bb77-8a90-31ea15a5597e@iogearbox.net>
Date:   Thu, 24 May 2018 12:33:02 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net
Cc:     alexei.starovoitov@...il.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next] bpfilter: don't pass O_CREAT when opening
 console for debug

On 05/24/2018 09:41 AM, Jakub Kicinski wrote:
> Passing O_CREAT (00000100) to open means we should also pass file
> mode as the third parameter.  Creating /dev/console as a regular
> file may not be helpful anyway, so simply drop the flag when
> opening debug_fd.
> 
> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Acked-by: Daniel Borkmann <daniel@...earbox.net>