netdev - Re: [PATCH net-next] net:sched: add action inheritdsfield to skbmod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4638a7a-1cf1-36c5-c540-340fb9376568@mojatatu.com>
Date:   Thu, 24 May 2018 08:11:54 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        "Fu, Qiaobin" <qiaobinf@...edu>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Michel Machado <michel@...irati.com.br>
Subject: Re: [PATCH net-next] net:sched: add action inheritdsfield to skbmod

On 23/05/18 07:01 PM, Cong Wang wrote:
> On Thu, May 17, 2018 at 12:33 PM, Fu, Qiaobin <qiaobinf@...edu> wrote:

> Hmm, but skbedit seems better than skbmod for this job,
> given:
> 
> 1) It already modifies skb->priority, although with a given value
> 
> 2) skbmod doesn't change skb metadata, it only changes payload
> 
> I am _not_ saying there is strict rule for what skbmod can or can't
> change, it calls itself "data modifier", so I am saying we probably
> need to follow this existing practice.
> 

I am indifferent - you can move it to skbedit.
Note: I have patches which i will send out at some point when
I get the chance on pedit for implementing the concept of
"copy data to metadata" and  "copy metadata to data"
for pedit it made a lot of sense to add the feature there.
In this case skbedit makes more sense.

cheers,
jamal