netdev - Re: [PATCH net-next] net: phy: convert further flags in struct phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a4cd053-74aa-17a9-1ce2-da4e3ae21809@gmail.com>
Date:   Thu, 24 May 2018 16:03:22 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        David Miller <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: convert further flags in struct
 phy_device to bit-field

On 05/24/2018 01:15 PM, Heiner Kallweit wrote:
> This patch is a follow-up to 87e5808d52b6 ("net: phy: replace bool
> members in struct phy_device with bit-fields") and converts further
> flags to bit-fields.

This looks fine, but then you would also have to clean-up all code that
does phydev->asym_pause = 1 and phydev->pause = 1 to use true/false
instead, I am not sure there is much value in doing that for these
fields considering that they are exposed to drivers so there is a risk
of possible breakage.

Thanks!

> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  include/linux/phy.h | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 6cd090984..cc66f2834 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -418,21 +418,20 @@ struct phy_device {
>  	/* The most recently read link state */
>  	unsigned link:1;
>  
> +	/* forced speed & duplex (no autoneg)
> +	 * partner speed & duplex & pause (autoneg)
> +	 */
> +	unsigned pause:1;
> +	unsigned asym_pause:1;
> +	int speed;
> +	int duplex;
> +
>  	enum phy_state state;
>  
>  	u32 dev_flags;
>  
>  	phy_interface_t interface;
>  
> -	/*
> -	 * forced speed & duplex (no autoneg)
> -	 * partner speed & duplex & pause (autoneg)
> -	 */
> -	int speed;
> -	int duplex;
> -	int pause;
> -	int asym_pause;
> -
>  	/* Enabled Interrupts */
>  	u32 interrupts;
>  
> 


-- 
Florian