netdev - Re: [PATCH net] net : sched: cls_api: deal with egdev path only if needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180524.221347.1439890185309496728.davem@davemloft.net>
Date:   Thu, 24 May 2018 22:13:47 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ogerlitz@...lanox.com
Cc:     jiri@...lanox.com, jakub.kicinski@...ronome.com,
        paulb@...lanox.com, netdev@...r.kernel.org,
        ASAP_Direct_Dev@...lanox.com
Subject: Re: [PATCH net] net : sched: cls_api: deal with egdev path only if
 needed

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Wed, 23 May 2018 19:24:48 +0300

> When dealing with ingress rule on a netdev, if we did fine through the
> conventional path, there's no need to continue into the egdev route,
> and we can stop right there.
> 
> Not doing so may cause a 2nd rule to be added by the cls api layer
> with the ingress being the egdev.
> 
> For example, under sriov switchdev scheme, a user rule of VFR A --> VFR B
> will end up with two HW rules (1) VF A --> VF B and (2) uplink --> VF B
> 
> Fixes: 208c0f4b5237 ('net: sched: use tc_setup_cb_call to call per-block callbacks')
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>

Applied and queued up for -stable.

> As I wrote in [1], we are asking this patch to go into net and 
> stable >= 4.15 but not carried into net-next.

Please send me a revert with a detailed commit message when this
gets merged into net-next.

Thanks.