netdev - Re: [PATCH net-next] ifb: fix packets checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180525.164337.1433478215018599363.davem@davemloft.net>
Date:   Fri, 25 May 2018 16:43:37 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jmaxwell37@...il.com
Cc:     dsahern@...il.com, mschiffer@...verse-factory.net,
        zhangshengju@...s.chinamobile.com, ktkhai@...tuozzo.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        jmaxwell@...hat.com
Subject: Re: [PATCH net-next] ifb: fix packets checksum

From: Jon Maxwell <jmaxwell37@...il.com>
Date: Fri, 25 May 2018 07:38:29 +1000

> Fixup the checksum for CHECKSUM_COMPLETE when pulling skbs on RX path. 
> Otherwise we get splats when tc mirred is used to redirect packets to ifb.
> 
> Before fix:
> 
> nic: hw csum failure
> 
> Signed-off-by: Jon Maxwell <jmaxwell37@...il.com>

This definitely seems correct, but I am really surprised a bug like this has
lasted as long as it has.

So I'll let this sit for another day or two for review.