netdev - Inefficient call to ipv6_chk_acast_addr_src in icmp6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAO7SqHDEVJiO_mrfQRntGL-C+KSARTjbezzx34CfPKjrFpxbLg@mail.gmail.com>
Date:   Fri, 25 May 2018 14:02:42 -0700
From:   Salam Noureddine <noureddine@...sta.com>
To:     Network Development <netdev@...r.kernel.org>
Subject: Inefficient call to ipv6_chk_acast_addr_src in icmp6_send

Hi,

The call to ipv6_chk_acast_addr_src in icmp6_send can be pretty costly on
systems with a lot of net_devices since it can end up looping through all
net_devices in a net namespace searching for an anycast address. A few
thousand icmp6 error packets can end up consuming a whole CPU.
I am thinking of fixing this by adding a hash table along the lines of
inet6_addr_lst,
providing a fast lookup for anycast addresses. Is that the right way to go?

Thanks,

Salam