netdev - Re: [v8, bpf-next, 4/9] net/wireless/iwlwifi: fix iwlwifi_dev_ucode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 May 2018 13:48:02 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Johannes Berg <johannes@...solutions.net>,
        Alexei Starovoitov <ast@...nel.org>, davem@...emloft.net,
        daniel@...earbox.net, torvalds@...ux-foundation.org,
        peterz@...radead.org, rostedt@...dmis.org,
        mathieu.desnoyers@...icios.com, netdev@...r.kernel.org,
        kernel-team@...com, linux-api@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [v8, bpf-next, 4/9] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint

Alexei Starovoitov <alexei.starovoitov@...il.com> writes:

> On Wed, May 23, 2018 at 01:03:08PM +0200, Johannes Berg wrote:
>> On Wed, 2018-03-28 at 12:05 -0700, Alexei Starovoitov wrote:
>> > fix iwlwifi_dev_ucode_error tracepoint to pass pointer to a table
>> > instead of all 17 arguments by value.
>> > dvm/main.c and mvm/utils.c have 'struct iwl_error_event_table'
>> > defined with very similar yet subtly different fields and offsets.
>> > tracepoint is still common and using definition of 'struct iwl_error_event_table'
>> > from dvm/commands.h while copying fields.
>> > Long term this tracepoint probably should be split into two.
>> 
>> It would've been nice to CC the wireless list for wireless related
>> patches ...
>
> Ohh. I didn't realize that networking wireless doesn't fall under netdev.
> I thought wireless folks are silent because they are embarrassed
> by a function with 17 arguments.

Really, this is the level of discussion now? You don't even bother to CC
the driver maintainers and your first reaction is that they are just too
embarrassed to answer? Oh man...

But if you continue doing these kind of "drive-by cleanups" to a
subsystem you are not familiar with, at least don't assume anything and
instead use get_maintainer script to find the maintainers so that the
patches get reviewed and applied to the correct tree:

$ scripts/get_maintainer.pl --no-rolestats --no-git -f drivers/net/wireless/intel/iwlwifi/dvm/main.c
Johannes Berg <johannes.berg@...el.com>
Emmanuel Grumbach <emmanuel.grumbach@...el.com>
Luca Coelho <luciano.coelho@...el.com>
Intel Linux Wireless <linuxwifi@...el.com>
Kalle Valo <kvalo@...eaurora.org>
"David S. Miller" <davem@...emloft.net>
Daniel Borkmann <daniel@...earbox.net>
Alexei Starovoitov <ast@...nel.org>
Kees Cook <keescook@...omium.org>
linux-wireless@...r.kernel.org
netdev@...r.kernel.org
linux-kernel@...r.kernel.org

-- 
Kalle Valo