netdev - Re: [PATCH v2 net-next] sfc: stop the TX queue before pushing new buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e0915e5-36a1-6373-2e95-6040c77824d9@solarflare.com>
Date:   Fri, 25 May 2018 12:57:20 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Martin Habets <mhabets@...arflare.com>,
        <linux-net-drivers@...arflare.com>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <jarod@...hat.com>
Subject: Re: [PATCH v2 net-next] sfc: stop the TX queue before pushing new
 buffers

On 24/05/18 10:14, Martin Habets wrote:
> efx_enqueue_skb() can push new buffers for the xmit_more functionality.
> We must stops the TX queue before this or else the TX queue does not get
> restarted and we get a netdev watchdog.
>
> In the error handling we may now need to unwind more than 1 packet, and
> we may need to push the new buffers onto the partner queue.
>
> v2: In the error leg also push this queue if xmit_more is set
>
> Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2")
> Reported-by: Jarod Wilson <jarod@...hat.com>
> Tested-by: Jarod Wilson <jarod@...hat.com>
> Signed-off-by: Martin Habets <mhabets@...arflare.com>
Acked-by: Edward Cree <ecree@...arflare.com>