lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 May 2018 15:04:37 +0300 From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com> To: Petr Machata <petrm@...lanox.com>, netdev@...r.kernel.org, devel@...verdev.osuosl.org, bridge@...ts.linux-foundation.org Cc: jiri@...lanox.com, idosch@...lanox.com, davem@...emloft.net, razvan.stefanescu@....com, gregkh@...uxfoundation.org, stephen@...workplumber.org, andrew@...n.ch, vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com Subject: Re: [PATCH net-next 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*() On 24/05/18 18:10, Petr Machata wrote: > A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves > initializing a struct switchdev_obj_port_vlan, a piece of code that > repeats on each call site almost verbatim. While in the current codebase > there is just one duplicated add call, the follow-up patches add more of > both add and del calls. > > Thus to remove the duplication, extract the repetition into named > functions and reuse. > > Signed-off-by: Petr Machata <petrm@...lanox.com> > --- > net/bridge/br_vlan.c | 44 +++++++++++++++++++++++--------------------- > 1 file changed, 23 insertions(+), 21 deletions(-) > Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Powered by blists - more mailing lists