netdev - Re: [PATCH, net-next] qcom-emag: hide ACPI specific functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d625691f-a240-23ee-3751-d577c5e72423@codeaurora.org>
Date:   Fri, 25 May 2018 19:22:09 -0500
From:   Timur Tabi <timur@...eaurora.org>
To:     Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Hemanth Puranik <hpuranik@...eaurora.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH, net-next] qcom-emag: hide ACPI specific functions

On 5/25/18 4:37 PM, Arnd Bergmann wrote:
> +#ifdef CONFIG_ACPI
>   static int emac_sgmii_irq_clear(struct emac_adapter *adpt, u8 irq_bits)
>   {
>   	struct emac_sgmii *phy = &adpt->phy;
> @@ -288,6 +289,7 @@ static struct sgmii_ops qdf2400_ops = {
>   	.link_change = emac_sgmii_common_link_change,
>   	.reset = emac_sgmii_common_reset,
>   };
> +#endif

This seems wrong.  The SGMII interrupt handler should still be viable on 
a device-tree system.  There is a DT compatibility entry for the qdf2432.

Looks like that most recent patch on net-next broke DT support, when it 
removed these lines:

-	phy->open = emac_sgmii_open;
-	phy->close = emac_sgmii_close;
-	phy->link_up = emac_sgmii_link_up;
-	phy->link_down = emac_sgmii_link_down;

I'll take it look at it next week when I'm back in the office.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.