netdev - Re: [PATCH v2 00/11] Modify action API for implementing lockless actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180527175739.GA3337@nanopsycho>
Date:   Sun, 27 May 2018 19:57:39 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...lanox.com, ast@...nel.org,
        daniel@...earbox.net, kliteyn@...lanox.com
Subject: Re: [PATCH v2 00/11] Modify action API for implementing lockless
 actions

Sun, May 27, 2018 at 06:41:27PM CEST, vladbu@...lanox.com wrote:

[...]

>Changes from V1 to V2:
>- Removed redundant actions ops lookup during delete.
>- Merge action ops delete definition and implementation.
>- Assume all actions have delete implemented and don't check for it
>  explicitly.
>- Resplit action lookup/release code to prevent memory leaks in
>  individual patches.
>- Make __tcf_idr_check function static
>- Remove unique idr insertion function. Change original idr insert to do
>  the same thing.
>- Merge changes that take reference to action when performing lookup and
>  changes that account for this additional reference when dumping action
>  to user space into single patch.
>- Change convoluted commit message.
>- Rename "unlocked" to "rtnl_held" for clarity.
>- Remove estimator lock add patch.
>- Refactor action check-alloc code into standalone function.
>- Rename tcf_idr_find_delete to tcf_idr_delete_index.
>- Rearrange variable definitions in tc_action_delete.
>- Add patch that refactors action API code to use array of pointers to
>  actions instead of intrusive linked list.
>- Expand cover letter.

With 11 patches, I'm unable to follow the changes in this description.
Could you please write the changes to each individual patch?
What I do is I write changes for each patch under "---" (there are two
"---" lines in each patch then. Then I also copy the changes descriptions
to the cover letter.

[...]