netdev - Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180528163949.GA17505@ziepe.ca>
Date:   Mon, 28 May 2018 10:39:49 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Greg Thelen <gthelen@...gle.com>
Cc:     arnd@...db.de, Doug Ledford <dledford@...hat.com>,
        Keith Busch <keith.busch@...el.com>, Jens Axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>, oleg.drokin@...el.com,
        andreas.dilger@...el.com, jsimmons@...radead.org,
        gregkh@...uxfoundation.org, Steve French <sfrench@...ba.org>,
        ericvh@...il.com, rminnich@...dia.gov, lucho@...kov.net,
        "David S. Miller" <davem@...emloft.net>,
        santosh.shilimkar@...cle.com, trond.myklebust@...merspace.com,
        anna.schumaker@...app.com, bfields@...ldses.org,
        jlayton@...nel.org, Bart Van Assche <bart.vanassche@....com>,
        linux-rdma@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-nvme@...ts.infradead.org, lustre-devel@...ts.lustre.org,
        devel@...verdev.osuosl.org, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org,
        v9fs-developer@...ts.sourceforge.net, netdev@...r.kernel.org,
        rds-devel@....oracle.com, linux-nfs@...r.kernel.org
Subject: Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig
 dependencies"

On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote:
> On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann <arnd@...db.de> wrote:
> 
> > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends
> > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a
> > link error when another driver using it is built-in. The
> > INFINIBAND_ADDR_TRANS dependency is insufficient here as this is
> > a 'bool' symbol that does not force anything to be a module in turn.
> 
> > fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work':
> > smbdirect.c:(.text+0x1e4): undefined reference to `rdma_disconnect'
> > net/9p/trans_rdma.o: In function `rdma_request':
> > trans_rdma.c:(.text+0x7bc): undefined reference to `rdma_disconnect'
> > net/9p/trans_rdma.o: In function `rdma_destroy_trans':
> > trans_rdma.c:(.text+0x830): undefined reference to `ib_destroy_qp'
> > trans_rdma.c:(.text+0x858): undefined reference to `ib_dealloc_pd'
> 
> > Fixes: 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig
> dependencies")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Acked-by: Greg Thelen <gthelen@...gle.com>
> 
> Sorry for the 9533b292a7ac problem.
> At this point the in release cycle, I think Arnd's revert is best.
> 
> If there is interest, I've put a little thought into an alternative fix:
> making INFINIBAND_ADDR_TRANS tristate.  But it's nontrivial.
> So I prefer this simple revert for now.

Is that a normal thing to do?

> Doug: do you need anything from me on this?

I can take the revert..

Jason