netdev - Re: [PATCH v3 08/11] net: sched: don't release reference on action overwrite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180528142738.GE2173@nanopsycho>
Date:   Mon, 28 May 2018 16:27:38 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, ast@...nel.org, daniel@...earbox.net,
        kliteyn@...lanox.com
Subject: Re: [PATCH v3 08/11] net: sched: don't release reference on action
 overwrite

Sun, May 27, 2018 at 11:17:26PM CEST, vladbu@...lanox.com wrote:
>Return from action init function with reference to action taken,
>even when overwriting existing action.
>
>Action init API initializes its fourth argument (pointer to pointer to tc
>action) to either existing action with same index or newly created action.
>In case of existing index(and bind argument is zero), init function returns
>without incrementing action reference counter. Caller of action init then
>proceeds working with action, without actually holding reference to it.
>This means that action could be deleted concurrently.
>
>Change action init behavior to always take reference to action before
>returning successfully, in order to protect from concurrent deletion.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Signed-off-by: Jiri Pirko <jiri@...lanox.com>