netdev - Re: [PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wih1sdufvx2.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Date:   Tue, 29 May 2018 16:12:09 +0300
From:   Petr Machata <petrm@...lanox.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     netdev@...r.kernel.org, devel@...verdev.osuosl.org,
        bridge@...ts.linux-foundation.org, f.fainelli@...il.com,
        andrew@...n.ch, nikolay@...ulusnetworks.com,
        gregkh@...uxfoundation.org, vivien.didelot@...oirfairelinux.com,
        idosch@...lanox.com, jiri@...lanox.com, razvan.stefanescu@....com,
        davem@...emloft.net
Subject: Re: [PATCH net-next v3 6/7] net: bridge: Notify about bridge VLANs

Dan Carpenter <dan.carpenter@...cle.com> writes:

> On Mon, May 28, 2018 at 05:11:04PM +0200, Petr Machata wrote:
>> @@ -580,6 +591,9 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags, bool *changed)
>>  			vg->num_vlans++;
>>  			*changed = true;
>>  		}
>> +		ret = br_switchdev_port_vlan_add(br->dev, vid, flags);
>> +		if (ret && ret != -EOPNOTSUPP)
>> +			return ret;
>
> We should probably do some error handling instead of returning directly?

I missed that, you are right. There's a bunch of mutations in the block
above.

Thanks,
Petr