netdev - Re: [PATCH net] net: sched: check netif_xmit_frozen_or_stopped() in sch_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180529.100255.625454563789387164.davem@davemloft.net>
Date:   Tue, 29 May 2018 10:02:55 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     songliubraving@...com
Cc:     netdev@...r.kernel.org, kernel-team@...com,
        john.fastabend@...il.com
Subject: Re: [PATCH net] net: sched: check netif_xmit_frozen_or_stopped()
 in sch_direct_xmit()

From: Song Liu <songliubraving@...com>
Date: Fri, 25 May 2018 11:11:44 -0700

> Summary:
> 
> At the end of sch_direct_xmit(), we are in the else path of
> !dev_xmit_complete(ret), which means ret == NETDEV_TX_OK. The following
> condition will always fail and netif_xmit_frozen_or_stopped() is not
> checked at all.
> 
>     if (ret && netif_xmit_frozen_or_stopped(txq))
>          return false;
> 
> In this patch, this condition is fixed as:
> 
>     if (netif_xmit_frozen_or_stopped(txq))
>          return false;
> 
> and further simplifies the code as:
> 
>     return !netif_xmit_frozen_or_stopped(txq);
> 
> Fixes: 29b86cdac00a ("net: sched: remove remaining uses for qdisc_qlen in xmit path")
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Song Liu <songliubraving@...com>

I expect a new version of this patch which removes the test entirely.