netdev - Re: [PATCH v2 net] tun: Fix NULL pointer dereference in XDP redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180529.110607.747104538345493769.davem@davemloft.net>
Date:   Tue, 29 May 2018 11:06:07 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     makita.toshiaki@....ntt.co.jp
Cc:     netdev@...r.kernel.org, jasowang@...hat.com
Subject: Re: [PATCH v2 net] tun: Fix NULL pointer dereference in XDP
 redirect

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Mon, 28 May 2018 19:37:49 +0900

> Calling XDP redirection requires bh disabled. Softirq can call another
> XDP function and redirection functions, then the percpu static variable
> ri->map can be overwritten to NULL.
 ...
> v2:
>  - Removed preempt_disable/enable since local_bh_disable will prevent
>    preemption as well, feedback from Jason Wang.
> 
> Fixes: 761876c857cb ("tap: XDP support")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied and queued up for -stable.