netdev - Re: [PATCH net-next 0/7] net/ipv6: Fix route append and replace use cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1527628562449.61262@alliedtelesis.co.nz>
Date:   Tue, 29 May 2018 21:16:02 +0000
From:   Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>
To:     David Ahern <dsahern@...il.com>,
        David Miller <davem@...emloft.net>,
        "dsahern@...nel.org" <dsahern@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "sharpd@...ulusnetworks.com" <sharpd@...ulusnetworks.com>,
        "roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>
Subject: Re: [PATCH net-next 0/7] net/ipv6: Fix route append and replace use
 cases

The only thing this breaks is adding IPv6 routes via ioctl. Previously they would be automatically appended to form multipath routes but this no longer occurs. Changing to netlink or use iproute2 and using NLM_F_APPEND gets around this. This basically what David Ahern said earlier but I wanted to make it clear the default ioctl behaviour has changed.
________________________________________
From: David Ahern <dsahern@...il.com>
Sent: 23 May 2018 08:44
To: David Miller; dsahern@...nel.org
Cc: netdev@...r.kernel.org; Thomas Winter; idosch@...lanox.com; sharpd@...ulusnetworks.com; roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next 0/7] net/ipv6: Fix route append and replace use cases

On 5/22/18 12:46 PM, David Miller wrote:
>
> Ok, I'll apply this series.
>
> But if this breaks things for anyone in a practical way, I am unfortunately
> going to have to revert no matter how silly the current behavior may be.
>

Understood. I have to try the best option first. I'll look at
regressions if they happen.