netdev - Re: [PATCH net-next] qmi_wwan: apply SET_DTR quirk to the SIMCOM shared device ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180528.231322.2155961010976328139.davem@davemloft.net>
Date:   Mon, 28 May 2018 23:13:22 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     bjorn@...k.no
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org, rspmn@...or.de
Subject: Re: [PATCH net-next] qmi_wwan: apply SET_DTR quirk to the SIMCOM
 shared device ID

From: Bjørn Mork <bjorn@...k.no>
Date: Fri, 25 May 2018 15:00:20 +0200

> SIMCOM are reusing a single device ID for many (all of their?)
> different modems, based on different chipsets and firmwares. Newer
> Qualcomm chipset generations require setting DTR to wake the QMI
> function.  The SIM7600E modem is using such a chipset, making it
> fail to work with this driver despite the device ID match.
> 
> Fix by unconditionally enabling the SET_DTR quirk for all SIMCOM
> modems using this specific device ID.  This is similar to what
> we already have done for another case of device IDs recycled over
> multiple chipset generations: 14cf4a771b30 ("drivers: net: usb:
> qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201")
> 
> Initial testing on an older SIM7100 modem shows no immediate side
> effects.
> 
> Reported-by: Sebastian Sjoholm <sebastian.sjoholm@...il.com>
> Cc: Reinhard Speyerer <rspmn@...or.de>
> Signed-off-by: Bjørn Mork <bjorn@...k.no>

Applied.