netdev - Re: [PATCH bpf-next 04/11] bpf: show prog and map id in fdinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180530191529.5af25d0a@redhat.com>
Date:   Wed, 30 May 2018 19:15:29 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Song Liu <liu.song.a23@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, brouer@...hat.com
Subject: Re: [PATCH bpf-next 04/11] bpf: show prog and map id in fdinfo

On Wed, 30 May 2018 09:15:25 -0700
Song Liu <liu.song.a23@...il.com> wrote:

> On Tue, May 29, 2018 at 12:55 PM, Daniel Borkmann <daniel@...earbox.net> wrote:
> > On 05/29/2018 07:27 PM, Jesper Dangaard Brouer wrote:  
> >> On Mon, 28 May 2018 02:43:37 +0200
> >> Daniel Borkmann <daniel@...earbox.net> wrote:
> >>  
> >>> Its trivial and straight forward to expose it for scripts that can
> >>> then use it along with bpftool in order to inspect an individual
> >>> application's used maps and progs. Right now we dump some basic
> >>> information in the fdinfo file but with the help of the map/prog
> >>> id full introspection becomes possible now.
> >>>
> >>> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> >>> Acked-by: Alexei Starovoitov <ast@...nel.org>  
> 
> Acked-by: Song Liu <songliubraving@...com>
> 
> >>
> >> AFAICR iproute uses this proc fdinfo, for pinned maps.  Have you tested
> >> if this change is handled gracefully by tc ?  
> >
> > Yep, it works just fine, I also tested it before submission.  

Sounds good.

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer