netdev - Re: [PATCH, net-next] net: ethernet: freescale: fix false-positive string overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180530.131859.1905291199897432856.davem@davemloft.net>
Date:   Wed, 30 May 2018 13:18:59 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     fugang.duan@....com, fabio.estevam@....com, andrew@...n.ch,
        troy.kisky@...ndarydevices.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH, net-next] net: ethernet: freescale: fix false-positive
 string overflow warning

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 28 May 2018 17:49:46 +0200

> While compile-testing on arm64 with gcc-8.1, I ran into a build diagnostic:
 ...
> It appears this has never shown on ppc32 or arm32 for an unknown reason, but
> now gcc fails to identify that the 'irq_cnt' loop index has an upper bound
> of 3, and instead uses a bogus range.
> 
> To work around the warning, this changes the sprintf to snprintf with the
> correct buffer length.
> 
> Fixes: 78cc6e7ef957 ("net: ethernet: freescale: Allow FEC with COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.