netdev - Re: [PATCH v5 net] stmmac: 802.1ad tag stripping fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8cdd4314-68d9-fe99-cce7-268d824725c1@lab.ntt.co.jp>
Date:   Wed, 30 May 2018 15:26:06 +0900
From:   Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
To:     Elad Nachman <eladv6@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, peppe.cavallaro@...com,
        alexandre.torgue@...com
Subject: Re: [PATCH v5 net] stmmac: 802.1ad tag stripping fix

On 2018/05/30 15:16, Elad Nachman wrote:
> Interesting question. That's the way the driver was originally written and I tried to minimize the changes in the patch.
> Anyway, common.h (included by stmmac_main.c) contains the following:
> 
> #if IS_ENABLED(CONFIG_VLAN_8021Q)
> #define STMMAC_VLAN_TAG_USED
> #include <linux/if_vlan.h>
> #endif
> 
> So the define in question kicks in only once you enable 802.1Q support in the kernel .config .

So, we end up with stripping vlan even though the device does not have
HW_VLAN_CTAG/STAG_RX when CONFIG_VLAN_8021Q is disabled, since the patch
anyway removed the original condition...

-- 
Toshiaki Makita