netdev - Re: [PATCH bpf 2/2] bpf: enforce usage of __aligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180530100319.GB5378@asgard.redhat.com>
Date:   Wed, 30 May 2018 12:03:19 +0200
From:   Eugene Syromiatnikov <esyr@...hat.com>
To:     Song Liu <liu.song.a23@...il.com>
Cc:     netdev@...r.kernel.org, open list <linux-kernel@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Lawrence Brakmo <brakmo@...com>, Andrey Ignatov <rdna@...com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        John Fastabend <john.fastabend@...il.com>,
        "Dmitry V. Levin" <ldv@...linux.org>
Subject: Re: [PATCH bpf 2/2] bpf: enforce usage of __aligned_u64 in the UAPI
 header

On Tue, May 29, 2018 at 10:35:09AM -0700, Song Liu wrote:
> I think these changes are not necessary. Is it a general guidance to
> only use 64-bit aligned
> variables in UAPI headers?

Not really, but it allows avoiding most alignment issues like the one
mentioned in the previous patch and in the referenced RDMA patch.