netdev - Re: [bpf-next V2 PATCH 6/8] xdp: done implementing ndo_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW4ceZf2Cy4VVesL6UrXV6TQ-kCJhNudDT1wDNyJ-MLAkg@mail.gmail.com>
Date:   Thu, 31 May 2018 09:16:20 -0700
From:   Song Liu <liu.song.a23@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     Networking <netdev@...r.kernel.org>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [bpf-next V2 PATCH 6/8] xdp: done implementing ndo_xdp_xmit flush
 flag for all drivers

On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer
<brouer@...hat.com> wrote:
> Removing XDP_XMIT_FLAGS_NONE as all driver now implement
> a flush operation in their ndo_xdp_xmit call.  The compiler
> will catch if any users of XDP_XMIT_FLAGS_NONE remains.
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

Acked-by: Song Liu <songliubraving@...com>

> ---
>  include/net/xdp.h |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/net/xdp.h b/include/net/xdp.h
> index 0c45f0f943ed..a3b71a4dd71d 100644
> --- a/include/net/xdp.h
> +++ b/include/net/xdp.h
> @@ -41,7 +41,6 @@ enum xdp_mem_type {
>  };
>
>  /* XDP flags for ndo_xdp_xmit */
> -#define XDP_XMIT_FLAGS_NONE    0U
>  #define XDP_XMIT_FLUSH         (1U << 0)       /* doorbell signal consumer */
>  #define XDP_XMIT_FLAGS_MASK    XDP_XMIT_FLUSH
>
>