netdev - Re: [PATCH net-next] qed: Add srq core support for RoCE and iWARP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180531173301.GV3697@mtr-leonro.mtl.com>
Date:   Thu, 31 May 2018 20:33:01 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Yuval Bason <yuval.bason@...ium.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jgg@...lanox.com,
        dledford@...hat.com, linux-rdma@...r.kernel.org,
        Michal Kalderon <michal.kalderon@...ium.com>,
        Ariel Elior <ariel.elior@...ium.com>
Subject: Re: [PATCH net-next] qed: Add srq core support for RoCE and iWARP

On Wed, May 30, 2018 at 04:11:37PM +0300, Yuval Bason wrote:
> This patch adds support for configuring SRQ and provides the necessary
> APIs for rdma upper layer driver (qedr) to enable the SRQ feature.
>
> Signed-off-by: Michal Kalderon <michal.kalderon@...ium.com>
> Signed-off-by: Ariel Elior <ariel.elior@...ium.com>
> Signed-off-by: Yuval Bason <yuval.bason@...ium.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_cxt.c   |   5 +-
>  drivers/net/ethernet/qlogic/qed/qed_cxt.h   |   1 +
>  drivers/net/ethernet/qlogic/qed/qed_hsi.h   |   2 +
>  drivers/net/ethernet/qlogic/qed/qed_iwarp.c |  23 ++++
>  drivers/net/ethernet/qlogic/qed/qed_main.c  |   2 +
>  drivers/net/ethernet/qlogic/qed/qed_rdma.c  | 179 +++++++++++++++++++++++++++-
>  drivers/net/ethernet/qlogic/qed/qed_rdma.h  |   2 +
>  drivers/net/ethernet/qlogic/qed/qed_roce.c  |  17 ++-
>  include/linux/qed/qed_rdma_if.h             |  12 +-
>  9 files changed, 235 insertions(+), 8 deletions(-)
>

...

> +	struct qed_sp_init_data init_data;

...

> +	memset(&init_data, 0, sizeof(init_data));

This patter is so common in this patch, why?

"struct qed_sp_init_data init_data = {};" will do the trick.

Thanks

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)