netdev - Re: [PATCH net] net/ncsi: Fix array size in dumpit handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180531.155930.1197591227145779002.davem@davemloft.net>
Date:   Thu, 31 May 2018 15:59:30 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     sam@...dozajonas.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        openbmc@...ts.ozlabs.org
Subject: Re: [PATCH net] net/ncsi: Fix array size in dumpit handler

From: Samuel Mendoza-Jonas <sam@...dozajonas.com>
Date: Thu, 31 May 2018 14:10:04 +1000

> With CONFIG_CC_STACKPROTECTOR enabled the kernel panics as below when
> parsing a NCSI_CMD_PKG_INFO command:
 ...
> This turns out to be because the attrs array in ncsi_pkg_info_all_nl()
> is initialised to a length of NCSI_ATTR_MAX which is the maximum
> attribute number, not the number of attributes.
> 
> Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
> Signed-off-by: Samuel Mendoza-Jonas <sam@...dozajonas.com>

Applied, thanks.