netdev - Re: [PATCH] samples/bpf: Add xdp_sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a7sgcg7i.fsf@toke.dk>
Date:   Thu, 31 May 2018 11:44:17 +0200
From:   Toke Høiland-Jørgensen <toke@...e.dk>
To:     Song Liu <liu.song.a23@...il.com>
Cc:     Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH] samples/bpf: Add xdp_sample_pkts example

Song Liu <liu.song.a23@...il.com> writes:

> On Wed, May 30, 2018 at 9:45 AM, Toke Høiland-Jørgensen <toke@...e.dk> wrote:
>> This adds an example program showing how to sample packets from XDP using
>> the perf event buffer. The example userspace program just prints the
>> ethernet header for every packet sampled.
>>
>> Most of the userspace code is borrowed from other examples, most notably
>> trace_output.
>>
>> Note that the example only works when everything runs on CPU0; so
>> suitable smp_affinity needs to be set on the device. Some drivers seem
>> to reset smp_affinity when loading an XDP program, so it may be
>> necessary to change it after starting the example userspace program.
>
> Why does this only works when everything runs on CPU0? Is this
> something we can improve?

Yeah, good question. Basically, the call from XDP to
bpf_perf_event_output() will fail with -EOPNOTSUPP. I tracked this down
to this if statement in __bpf_perf_event_output() in bpf_trace.c:

>	if (unlikely(event->oncpu != cpu))
>		return -EOPNOTSUPP;

I *think* that the way to fix this is for the userspace program to open
a perf file descriptor for each CPU in the system and poll all of them,
in which case the XDP program can pass the BPF_F_CURRENT_CPU flag to
access the right one. I would love for someone more knowledgeable about
perf internals to confirm this, though.

And, well, the polling function in trace_helpers.c doesn't support
currently this, and I didn't have the time to fix that while writing
this example :)

-Toke