netdev - Re: [PATCH net-next v4 00/11] Modify action API for implementing lockless actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262fbd11-401e-90cf-4226-39b1604eb16d@mojatatu.com>
Date:   Thu, 31 May 2018 06:01:32 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Vlad Buslov <vladbu@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, xiyou.wangcong@...il.com, jiri@...nulli.us,
        pablo@...filter.org, kadlec@...ckhole.kfki.hu, fw@...len.de,
        ast@...nel.org, daniel@...earbox.net, edumazet@...gle.com,
        keescook@...omium.org, marcelo.leitner@...il.com,
        kliteyn@...lanox.com
Subject: Re: [PATCH net-next v4 00/11] Modify action API for implementing
 lockless actions

Hi Vlad,

Can you try one simple test below with these patches?

#create an action
sudo $TC actions add action skbedit mark 1 pipe
#
sudo $TC qdisc del dev lo parent ffff:
sudo $TC qdisc add dev lo ingress
# bind action to filter....
sudo $TC filter add dev lo parent ffff: protocol ip prio 1 \
u32 match ip dst 127.0.0.1/32 flowid 1:1 action skbedit index 1

#now delete that action multiple times while it is still bound
sudo $TC actions del action skbedit index 1
sudo $TC actions del action skbedit index 1
sudo $TC actions del action skbedit index 1

#check the refcount and bindcount
sudo $TC -s actions ls action skbedit

#delete the filter (which should remove the bindcnt)

sudo $TC filter del dev lo parent ffff: protocol ip prio 1 \
u32 match ip dst 127.0.0.1/32 flowid 1:1

#check the refcount and bindcount
sudo $TC -s actions ls action skbedit

Current behavior: i believe the action is gone in this last step.
Your patches may change behavior so that the action action is still
around. I dont think this is a big deal, but just wanted to be sure
it is not something more unexpected.

cheers,
jamal