netdev - Re: [PATCH net-next v4 00/11] Modify action API for implementing lockless actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <vbf4limilfk.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
Date:   Fri, 01 Jun 2018 18:19:27 +0300
From:   Vlad Buslov <vladbu@...lanox.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        xiyou.wangcong@...il.com, jiri@...nulli.us, pablo@...filter.org,
        kadlec@...ckhole.kfki.hu, fw@...len.de, ast@...nel.org,
        daniel@...earbox.net, edumazet@...gle.com, keescook@...omium.org,
        marcelo.leitner@...il.com, kliteyn@...lanox.com
Subject: Re: [PATCH net-next v4 00/11] Modify action API for implementing lockless actions


On Fri 01 Jun 2018 at 12:24, Jamal Hadi Salim <jhs@...atatu.com> wrote:
> On 31/05/18 08:38 AM, Vlad Buslov wrote:
>
>> Hi Jamal,
>> 
>> On current net-next I still have action with single reference after last
>> step:
>> ~$ sudo $TC -s actions ls action skbedit
>> total acts 1
>>                                                                 
>>          action order 0:  skbedit mark 1 pipe
>>           index 1 ref 2 bind 1 installed 47 sec used 47 sec
>>          Action statistics:
>>          Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>>          backlog 0b 0p requeues 0
>> ~$ sudo $TC filter del dev lo parent ffff: protocol ip prio 1 \
>>> u32 match ip dst 127.0.0.1/32 flowid 1:1
>> ~$ sudo $TC -s actions ls action skbedit
>> total acts 1
>>                                                                 
>>          action order 0:  skbedit mark 1 pipe
>>           index 1 ref 1 bind 0 installed 80 sec used 80 sec
>>          Action statistics:
>>          Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>>          backlog 0b 0p requeues 0
>> 
>> Which branch are you testing on?
>
> You are correct - this is how it works now (I was thinking of a
> very old version before Cong made some changes a while back).
> Just vet this continues to work as above.
>
> cheers,
> jamal

Indeed, there was a problem that changed a behavior in this case.
I fixed it, re-run the test suite, manually checked with test you
proposed in this thread, and sent V5.

Thanks,
Vlad