netdev - Re: [PATCH iproute2] iplink_vrf: Save device index from response for return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180601170549.GO16785@orbyte.nwl.cc>
Date:   Fri, 1 Jun 2018 19:05:49 +0200
From:   Phil Sutter <phil@....cc>
To:     dsahern@...nel.org
Cc:     stephen@...workplumber.org, netdev@...r.kernel.org,
        David Ahern <dsahern@...il.com>,
        Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCH iproute2] iplink_vrf: Save device index from response for
 return code

On Fri, Jun 01, 2018 at 08:50:16AM -0700, dsahern@...nel.org wrote:
> From: David Ahern <dsahern@...il.com>
> 
> A recent commit changed rtnl_talk_* to return the response message in
> allocated memory so callers need to free it. The change to name_is_vrf
> did not save the device index which is pointing to a struct inside the
> now allocated and freed memory resulting in garbage getting returned
> in some cases.
> 
> Fix by using a stack variable to save the return value and only set
> it to ifi->ifi_index after all checks are done and before the answer
> buffer is freed.
> 
> Fixes: 86bf43c7c2fdc ("lib/libnetlink: update rtnl_talk to support malloc buff at run time")
> Cc: Hangbin Liu <liuhangbin@...il.com>
> Cc: Phil Sutter <phil@....cc>
> Signed-off-by: David Ahern <dsahern@...il.com>

Acked-by: Phil Sutter <phil@....cc>

Thanks, Phil