netdev - Re: [PATCH] net: core: improve the tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180601.132719.127789157890409297.davem@davemloft.net>
Date:   Fri, 01 Jun 2018 13:27:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: core: improve the tx_hash calculating

From: Tonghao Zhang <xiangxia.m.yue@...il.com>
Date: Thu, 31 May 2018 03:14:01 -0700

> Use the % instead of while, and it may simple code and improve
> the calculating. The real_num_tx_queues has been checked when
> allocating and setting it.
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>

The loop is there to avoid the expensive modulus operation,
not to avoid the real_num_tx_queues == 0 case.