netdev - Re: [bpf PATCH v2] bpf: sockmap, fix crash when ipv6 sock is added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13d3be75-4ed2-aeca-caba-797766e9b676@gmail.com>
Date:   Fri, 1 Jun 2018 15:58:52 -0400
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     John Fastabend <john.fastabend@...il.com>, edumazet@...gle.com,
        ast@...nel.org, daniel@...earbox.net
Cc:     netdev@...r.kernel.org
Subject: Re: [bpf PATCH v2] bpf: sockmap, fix crash when ipv6 sock is added



On 06/01/2018 03:46 PM, John Fastabend wrote:
> This fixes a crash where we assign tcp_prot to IPv6 sockets instead
> of tcpv6_prot.

...

> +	/* ULPs are currently supported only for TCP sockets in ESTABLISHED
> +	 * state. Supporting sockets in LISTEN state will require us to
> +	 * modify the accept implementation to clone rather then share the
> +	 * ulp context.
> +	 */
> +	if (sock->sk_state != TCP_ESTABLISHED)
> +		return -ENOTSUPP;
> +
>  	/* 1. If sock map has BPF programs those will be inherited by the
>  	 * sock being added. If the sock is already attached to BPF programs
>  	 * this results in an error.
> 

Next question will be then : What happens if syzbot uses tcp_disconnect() and then listen() ?

Thanks !