netdev - Re: [PATCH rdma-next v3 00/14] Verbs flow counters support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180601211149.GA24028@ziepe.ca>
Date:   Fri, 1 Jun 2018 15:11:49 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Boris Pismenny <borisp@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        "Michael J . Ruhl" <michael.j.ruhl@...el.com>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Raed Salem <raeds@...lanox.com>,
        Yishai Hadas <yishaih@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH rdma-next v3 00/14] Verbs flow counters support

On Thu, May 31, 2018 at 04:43:27PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...lanox.com>
> 
> Changelog:
> v2->v3:
>  * Change function mlx5_fc_query signature to hide the details of
>    internal core driver struct mlx5_fc
>  * Add commen to data[] field at struct mlx5_ib_flow_counters_data (mlx5-abi.h)
>  * Use array of struct mlx5_ib_flow_counters_desc to clarify the output
> v1->v2:
>  * Removed conversion from struct mlx5_fc* to void*
>  * Fixed one place with double space in it
>  * Balanced release of hardware handler in case of counters allocation failure
>  * Added Tested-by
>  * Minimize time spent holding mutex lock
>  * Fixed deadlock caused by nested lock in error path
>  * Protect from handler pointer derefence in the error paths

Okay,

Acked-by: Jason Gunthorpe <jgg@...lanox.com>

I've revised some of the commit messages, fixed the two bad
check-patch warnings, and fixed the patch ordering..

https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=wip/jgg-counters

Please send a PR with the mlx-core bits and above commits.

Thanks,
Jason