netdev - Re: [PATCH bpf-next] bpf: prevent non-IPv4 socket to be added into sock hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLocj4Gth3R0+a4ppRhYHV=buWSgfEYLg+zJay25D477g@mail.gmail.com>
Date:   Thu, 31 May 2018 21:00:23 -0400
From:   Eric Dumazet <edumazet@...gle.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Wei Wang <weiwan@...gle.com>, netdev <netdev@...r.kernel.org>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH bpf-next] bpf: prevent non-IPv4 socket to be added into
 sock hash

On Thu, May 31, 2018 at 7:32 PM John Fastabend <john.fastabend@...il.com> wrote:
>
>
> Hi Wei,
>
> Thanks for the report and fix. It would be better to fix the
> root cause so that IPv6 works as intended.
>
> I'm testing the following now,
>
> Author: John Fastabend <john.fastabend@...il.com>
> Date:   Thu May 31 14:38:59 2018 -0700
>
>     sockmap: fix crash when ipv6 sock is added by adding support for IPv6
>
>     Apparently we had a testing escape and missed IPv6. This fixes a crash
>     where we assign tcp_prot to IPv6 sockets instead of tcpv6_prot.
>
>     Signed-off-by: John Fastabend <john.fastabend@...il.com>
>

Hi John

In any case, please forward correct attribution for Wei's work, and
syzbot 'Reported-by'

Are you sure you are handling IPv4 mapped in IPv6 sockets as well ?

Thanks.