netdev - Re: [PATCH] netfilter: nft_numgen: fix ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180601074639.ptk6zpp2crvunzap@salvia>
Date:   Fri, 1 Jun 2018 09:46:39 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Laura Garcia <nevola@...il.com>
Cc:     kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        Netfilter Development Mailing list 
        <netfilter-devel@...r.kernel.org>, coreteam@...filter.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: nft_numgen: fix ptr_ret.cocci warnings

On Thu, May 24, 2018 at 12:40:04PM +0200, Laura Garcia wrote:
> On Wed, May 23, 2018 at 12:58 PM, kbuild test robot
> <fengguang.wu@...el.com> wrote:
> > From: kbuild test robot <fengguang.wu@...el.com>
> >
> > net/netfilter/nft_numgen.c:117:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> >
> >
> >  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> >
> > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> >
> > Fixes: d734a2888922 ("netfilter: nft_numgen: add map lookups for numgen statements")
> > CC: Laura Garcia Liebana <nevola@...il.com>
> > Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
> 
> Acked-by: Laura Garcia Liebana <nevola@...il.com>

Applied, thanks.