netdev - Re: [PATCH net-next 1/5] net: aquantia: Ethtool based ring size configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc8462a8-cd62-9da0-18e7-eb3cf488977a@aquantia.com>
Date:   Fri, 1 Jun 2018 12:19:33 +0300
From:   Igor Russkikh <igor.russkikh@...antia.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        David Arcari <darcari@...hat.com>,
        Pavel Belous <pavel.belous@...antia.com>,
        Anton Mikaev <amikaev@...antia.com>
Subject: Re: [PATCH net-next 1/5] net: aquantia: Ethtool based ring size
 configuration


>> +
>> +	spin_lock(&aq_nic->aq_spinlock);
>> +
>> +	if (netif_running(ndev))
>> +		dev_close(ndev);
> 
> I don't think you can hold a spinlock around dev_close()/dev_open()
> calls.

Thanks Jakub, think you are right, will consider changing this lock to mutex.

>> +	if (!netif_running(ndev))
>> +		err = dev_open(ndev);
> 
> Will this not open the device regardless if it was open before or not?

Correct, thanks!

BR, Igor