netdev - Re: [PATCH net-next] rtnetlink: Fix null-ptr-deref in rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180601.103955.560700444664349840.davem@davemloft.net>
Date:   Fri, 01 Jun 2018 10:39:55 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     bhole_prashant_q7@....ntt.co.jp
Cc:     edumazet@...gle.com, daniel@...earbox.net, ast@...nel.org,
        ktkhai@...tuozzo.com, fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] rtnetlink: Fix null-ptr-deref in rtnl_newlink

From: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
Date: Fri,  1 Jun 2018 17:16:58 +0900

> In rtnl_newlink(), NULL check is performed on m_ops however member of
> ops is accessed. Fixed by accessing member of m_ops instead of ops.
> 
> [  345.432629] BUG: KASAN: null-ptr-deref in rtnl_newlink+0x400/0x1110
> [  345.432629] Read of size 4 at addr 0000000000000088 by task ip/986
> [  345.432629]
> [  345.432629] CPU: 1 PID: 986 Comm: ip Not tainted 4.17.0-rc6+ #9
> [  345.432629] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
> [  345.432629] Call Trace:
> [  345.432629]  dump_stack+0xc6/0x150
> [  345.432629]  ? dump_stack_print_info.cold.0+0x1b/0x1b
> [  345.432629]  ? kasan_report+0xb4/0x410
> [  345.432629]  kasan_report.cold.4+0x8f/0x91
> [  345.432629]  ? rtnl_newlink+0x400/0x1110
> [  345.432629]  rtnl_newlink+0x400/0x1110
> [...]
> 
> Fixes: ccf8dbcd062a ("rtnetlink: Remove VLA usage")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>

Applied, thanks.