netdev - Re: [PATCH bpf] bpf: fix uapi hole for 32 bit compat applications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180602035021.27s6d672su3wxwhs@ast-mbp>
Date:   Fri, 1 Jun 2018 23:50:23 -0400
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     ast@...nel.org, netdev@...r.kernel.org,
        jakub.kicinski@...ronome.com, kafai@...com, songliubraving@...com,
        ldv@...linux.org, esyr@...hat.com
Subject: Re: [PATCH bpf] bpf: fix uapi hole for 32 bit compat applications

On Sat, Jun 02, 2018 at 05:21:59AM +0200, Daniel Borkmann wrote:
> In 64 bit, we have a 4 byte hole between ifindex and netns_dev in the
> case of struct bpf_map_info but also struct bpf_prog_info. In net-next
> commit b85fab0e67b ("bpf: Add gpl_compatible flag to struct bpf_prog_info")
> added a bitfield into it to expose some flags related to programs. Thus,
> add an unnamed __u32 bitfield for both so that alignment keeps the same
> in both 32 and 64 bit cases, and can be naturally extended from there
> as in b85fab0e67b.
> 
> 
> Reported-by: Dmitry V. Levin <ldv@...linux.org>
> Reported-by: Eugene Syromiatnikov <esyr@...hat.com>
> Fixes: 52775b33bb507 ("bpf: offload: report device information about offloaded maps")
> Fixes: 675fc275a3a2d ("bpf: offload: report device information for offloaded programs")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Applied, Thanks.