netdev - Re: [PATCH net] net/ipv6: prevent use after free in ip6_route_mpath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5092b96-9e0e-c5e5-8042-06f3ce5b0c78@gmail.com>
Date:   Mon, 4 Jun 2018 13:45:43 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     dsahern@...nel.org, netdev@...r.kernel.org
Cc:     David Ahern <dsahern@...il.com>, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] net/ipv6: prevent use after free in
 ip6_route_mpath_notify



On 06/04/2018 01:41 PM, dsahern@...nel.org wrote:
> From: David Ahern <dsahern@...il.com>
> 
> syzbot reported a use-after-free:
> 
> BUG: KASAN: use-after-free in ip6_route_mpath_notify+0xe9/0x100 net/ipv6/route.c:4180
> Read of size 4 at addr ffff8801bf789cf0 by task syz-executor756/4555
> 
> Fix by not setting rt_last until the it is verified the insert succeeded.
> 
> Fixes: 3b1137fe7482 ("net: ipv6: Change notifications for multipath add to RTA_MULTIPATH")
> Cc: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks David !