netdev - Re: [PATCH net-next V2 2/2] cls_flower: Fix comparing of old filter mask with new filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180604.170415.2271439758154626128.davem@davemloft.net>
Date:   Mon, 04 Jun 2018 17:04:15 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     paulb@...lanox.com
Cc:     jiri@...lanox.com, xiyou.wangcong@...il.com, jhs@...atatu.com,
        netdev@...r.kernel.org, kliteyn@...lanox.com, roid@...lanox.com,
        shahark@...lanox.com, markb@...lanox.com, ogerlitz@...lanox.com
Subject: Re: [PATCH net-next V2 2/2] cls_flower: Fix comparing of old
 filter mask with new filter

From: Paul Blakey <paulb@...lanox.com>
Date: Sun,  3 Jun 2018 10:06:14 +0300

> We incorrectly compare the mask and the result is that we can't modify
> an already existing rule.
> 
> Fix that by comparing correctly.
> 
> Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority")
> Reported-by: Vlad Buslov <vladbu@...lanox.com>
> Reviewed-by: Roi Dayan <roid@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Paul Blakey <paulb@...lanox.com>

Applied.