[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180604152324.6e1115a2@cakuba.netronome.com>
Date: Mon, 4 Jun 2018 15:26:02 -0700
From: Jakub Kicinski <kubakici@...pl>
To: Toke Høiland-Jørgensen <toke@...e.dk>
Cc: netdev@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net>,
Alexei Starovoitov <alexei.starovoitov@...il.com>
Subject: Re: [PATCH bpf-next v2 1/2] trace_helpers.c: Add helpers to poll
multiple perf FDs for events
On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote:
> This adds two new helper functions to trace_helpers that supports polling
> multiple perf file descriptors for events. These are used to the XDP
> perf_event_output example, which needs to work with one perf fd per CPU.
>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...e.dk>
Did you take a look at tools/bpf/bpftool/map_perf_ring.c ?
I think the ability to poll multiple FDs could be generally useful and
therefore better add it to libbpf.c than
tools/testing/selftests/bpf/trace_helpers.c? I'm not 100% sure myself...
Powered by blists - more mailing lists