netdev - Re: [PATCH net-next 2/3] netdevsim: Add extack error message for devlink reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180604154712.42aa1885@cakuba.netronome.com>
Date:   Mon, 4 Jun 2018 15:47:12 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, jiri@...lanox.com,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next 2/3] netdevsim: Add extack error message for
 devlink reload

On Mon,  4 Jun 2018 15:15:02 -0700, dsahern@...nel.org wrote:
> From: David Ahern <dsahern@...il.com>
> 
> devlink reset command can fail if a FIB resource limit is set to a value
> lower than the current occupancy. Return a proper message indicating the
> reason for the failure.
> 
> $ devlink resource sh netdevsim/netdevsim0
> netdevsim/netdevsim0:
>   name IPv4 size unlimited unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>     resources:
>       name fib size unlimited occ 43 unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>       name fib-rules size unlimited occ 4 unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>   name IPv6 size unlimited unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>     resources:
>       name fib size unlimited occ 54 unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
>       name fib-rules size unlimited occ 3 unit entry size_min 0 size_max unlimited size_gran 1 dpipe_tables none
> 
> $ devlink resource set netdevsim/netdevsim0 path /IPv4/fib size 40
> 
> $ devlink dev  reload netdevsim/netdevsim0
> Error: netdevsim: New size is less than current occupancy.
> devlink answers: Invalid argument
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

The entire set looks very useful, thanks!