netdev - Re: [PATCH net-next v11 03/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet Nexus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180605001052.GA18073@lunn.ch>
Date:   Tue, 5 Jun 2018 02:10:52 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "Steven J. Hill" <steven.hill@...ium.com>
Cc:     netdev@...r.kernel.org, Carlos Munoz <cmunoz@...ium.com>
Subject: Re: [PATCH net-next v11 03/10] netdev: cavium: octeon: Add Octeon
 III BGX Ethernet Nexus

> +		/* Connect to PKI/PKO */
> +		data = oct_csr_read(BGX_CMR_CONFIG(numa_node, interface, port));
> +		if (is_mix)
> +			data |= BIT(11);
> +		else
> +			data &= ~BIT(11);
> +		oct_csr_write(data, BGX_CMR_CONFIG(numa_node, interface, port));
> +

Hi Steven

This driver has quite a lot of magic BIT macros. Can you add some
#defines with useful names?

	 Thanks
		Andrew